implement code review feedback

Signed-off-by: tarilabs <[email protected]>
containers · Feb 18, 2025 · e9160e2 · e9160e2
1 parent 9c2c96d
commit e9160e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -51,7 +51,7 @@ jobs:
         OCI_REGISTRY_DESTINATION=localhost:5001/nstestorg/modelcar
         rm -rf $IMAGE_DIR
         skopeo copy --multi-arch all docker://${OCI_REGISTRY_SOURCE} oci:${IMAGE_DIR}:latest
-        poetry run olot $IMAGE_DIR tests/data/sample-model/model.joblib --modelcard tests/data/sample-model/README.md
+        poetry run olot $IMAGE_DIR --modelcard tests/data/sample-model/README.md tests/data/sample-model/model.joblib
         # copy modelcar from oci-layout to the local docker registry
         skopeo copy --tls-verify=false --multi-arch all oci:${IMAGE_DIR}:latest docker://${OCI_REGISTRY_DESTINATION}
         # make sure the annotation is present

diff --git a/README.md b/README.md
@@ -25,7 +25,7 @@ skopeo copy --multi-arch all docker://${OCI_REGISTRY_SOURCE} oci:${IMAGE_DIR}:la
 # chmod +w ${IMAGE_DIR}/blobs/sha256/*
 
 # Appends to the image found in `download` the files `model.joblib` and as ModelCarD the `README.md`
-poetry run olot $IMAGE_DIR tests/data/sample-model/model.joblib --modelcard tests/data/sample-model/README.md
+poetry run olot $IMAGE_DIR --modelcard tests/data/sample-model/README.md tests/data/sample-model/model.joblib
 
 # Pushes the (updated) image found in `download` folder to the registry `quay.io/mmortari/demo20241208` with tag `latest`
 skopeo copy --multi-arch all oci:${IMAGE_DIR}:latest docker://${OCI_REGISTRY_DESTINATION}