Test win-sshproxy with qemu VM #449
Conversation
Tests that are currently on the main branch only runs against a qemu VM. We have other use cases that needs to be tested like running against a vfkit VM. This commit reorganizes the tests code a bit by moving the files that can be shared to support different implementation in their own folder. The reasoning behind this is that every hypervisor should have its own beforeSuite func to download/run a specific VM image. By moving the utils files we can reuse the same code. For the same reason the code targeting qemu is moved to the test-qemu folder. By doing so, we can run the tests within the test-qemu folder on the ubuntu workflow and, in future, when the nested virt will be enabled on github runners, the vfkit tests on macOS. Signed-off-by: Luca Stocchi <[email protected]>
Adds a basic implementation for testing against a vfkit VM. Tests are based on the existing qemu version. It just changes the way the VM gets created/started. Signed-off-by: Luca Stocchi <[email protected]>
it adds the logic to test win-sshproxy by using a qemu VM with fcos and see if the ssh tunneling between host/guest on the podman socket works as expected. The qemu VM can also be reused for further extensive testing Signed-off-by: lstocchi <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lstocchi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| } | ||
| defer file.Close() | ||
|
|
||
| // using bufio.NewReader speeds up the decompressions -> https://github.com/ulikunitz/xz/issues/23 |
There was a problem hiding this comment.
even with the bufio reader, it is still a lot slower than the external tool? crc uses https://github.com/xi2/xz?tab=readme-ov-file for xz decompression, but I think it is also slower than native xz. And it hasn't seen any updates in years.
it adds the logic to test win-sshproxy by using a qemu VM with fcos and see if the ssh tunneling between host/guest on the podman socket works as expected.
The qemu VM can also be reused for further extensive testing.
It is based on #427