Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signed off by: Amit Pandey <[email protected]> #1656

Closed
wants to merge 7 commits into from

Conversation

d4v1d03
Copy link

@d4v1d03 d4v1d03 commented Aug 29, 2023

What type of PR is this?

though it's a regular PR but it's some sort of draft PR because i did not have regular contact with the mentor during this work.

/kind feature

What this PR does / why we need it:

This PR has been made to implement the JSONLogger for this project,

Which issue(s) this PR fixes:

This PR fixes the issue #1126 (Add support for additional log drivers).

Special notes for your reviewer:

I have tried my best to work up with the JSONLogger.rs though i could not maintain adequate communication with @haircommander but i'd like to work over this project under the LFX upcoming term. I have good knowledge of containers and docker internals along with working with Kubernetes though i have a security and blockchain background as submitted in my application and resume. I have tried contacting Peter Hunt on slack and hope i get to work under him as my mentor for this, my collegaues at CNCF have mentioned him multiple times while discussing about CRI-O.

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: d4v1d03
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant