Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple changes for the next release (0.4.0) #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ka7eh
Copy link
Collaborator

@ka7eh ka7eh commented Jan 12, 2020

Apply the following changes:

  • Add allowRemove option for legends
  • Move disableVisibilityControls from control options to legend options
  • Fix an issue caused by missing html key in legend elements props

@nikmolnar looks like I don't have write access to this repo. Do you mind reviewing this PR and creating a new release for it? Thanks.

@ka7eh ka7eh changed the title Add allowRemove option Add allowRemove option and move disableVisibilityControls from control options to legend options Jan 12, 2020
@ka7eh ka7eh changed the title Add allowRemove option and move disableVisibilityControls from control options to legend options Multiple changes for the next release (0.4.0) Jan 12, 2020
@brentfraser
Copy link

Looks good to me.

@joffreyj
Copy link

Any updates on when these changes will be released? Particularly interested #10.

@ka7eh
Copy link
Collaborator Author

ka7eh commented Feb 11, 2020

I'll try to release a new version on npm today or tomorrow.
@nikmolnar can you give me write access to this repo so I can merge the PR to master?

@ka7eh
Copy link
Collaborator Author

ka7eh commented Feb 13, 2020

@joffreyj I published a new version to npm. I'll merge the PR into master too as soon as I get write access to the repo.

@joffreyj
Copy link

joffreyj commented Feb 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants