-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple changes for the next release (0.4.0) #13
Open
ka7eh
wants to merge
3
commits into
consbio:master
Choose a base branch
from
ka7eh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good to me. |
Any updates on when these changes will be released? Particularly interested #10. |
I'll try to release a new version on npm today or tomorrow. |
@joffreyj I published a new version to npm. I'll merge the PR into master too as soon as I get write access to the repo. |
Go a chance to pull this down and look at it... not exactly what I was
talking about... I was hoping to be able to remove the map and all from
menu.
I would like for the user to be able to remove the entry from the legend
altogether. I hope the screen shot clears this up, I do want to thank you
for your time you put into this.
…On Wed, Feb 12, 2020 at 6:03 PM Kaveh ***@***.***> wrote:
@joffreyj <https://github.com/joffreyj> I published a new version to npm.
I'll merge the PR into master too as soon as I get write access to the repo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13?email_source=notifications&email_token=ABSNR3G7NEV5O7PEXZFCVKDRCSE5TA5CNFSM4KFVT232YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELS3S4Y#issuecomment-585480563>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSNR3G3EIVELX6G3JGHUFTRCSE5TANCNFSM4KFVT23Q>
.
--
Geoffrey Joseph *|* Enterprise Web Developer
IT Services
University of Arkansas at Little Rock
501.916.3010 *|* [email protected] *|* ualr.edu
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the following changes:
allowRemove
option for legendsdisableVisibilityControls
from control options to legend optionshtml
key in legend elements props@nikmolnar looks like I don't have write access to this repo. Do you mind reviewing this PR and creating a new release for it? Thanks.