-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wean schema subject quickpick off of getSubjects() / GET /schemas
route
#1005
Wean schema subject quickpick off of getSubjects() / GET /schemas
route
#1005
Conversation
…w schema) now based off of `GET /subjects` route results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- CHANGELOG.md: Evaluated as low risk
Comments suppressed due to low confidence (3)
src/quickpicks/schemas.ts:15
- The parameter 'defaultSubject' is no longer used and should be removed from the function signature.
defaultSubject: string | undefined = undefined,
src/commands/schemaUpload.ts:222
- The comment mentions 'schema type' which is no longer a parameter of the function. It should be updated to reflect the current function signature.
// using the given schema type. Will return "" if they want to create a new subject.
src/commands/schemaUpload.ts:222
- The comment mentions 'defaultSubject' which is no longer a parameter of the function. It should be updated to reflect the current function signature.
// using the given schema type. Will return "" if they want to create a new subject.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/quickpicks/schemas.ts: Evaluated as low risk
if (schemas === undefined) { | ||
schemaSubjects = []; | ||
} | ||
const schemaSubjects = await loader.getSubjects(schemaRegistry); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core change right here. Basing schemaSubjectQuickPick
on top of loader.getSubjects(schemaRegistry)
returning the sorted subject names instead of loader.getSchemasForRegistry(schemaRegistry)
returning all the schema metadatas.
…jectquickpick-to-use-new-resourceloadergetsubjects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/commands/schemaUpload.ts: Evaluated as low risk
GET /schemas
routeGET /schemas
route
Summary of Changes
schemaSubjectQuickPick()
, the quickpick for schema registry subject names (i.e. when uploading a new or revised schema) now based off ofGET /subjects
route results as from the newResourceLoader
method. Respelling this was low-hanging fruit in revising all callers togetSchemas()
.schemaSubjectQuickPick()
andchooseSubject()
drop their schema type parameter.chooseSubject()
orschemaSubjectQuickPick()
provides thedefaultSubject
parameter anymore (was legacy from the original "evolve schema" implementation that depended on metadata attached to the editor buffer), so get rid of it. Alas, we hardly knew ye.Any additional details or context that should be provided?
Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Other
.vsix
file?