Fix assignment lost, on illegal generation, during a commit #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
emasab
commented
Nov 20, 2024
| /* Revoke assignment and rebalance on illegal generation, | ||
| * only if not rebalancing, because a new generation id | ||
| * can be received soon after this error. */ | ||
| if (RD_KAFKA_CGRP_REBALANCING(rkcg)) |
There was a problem hiding this comment.
Setting rk->rk_cgrp->rkcg_generation_id to -1, even if not initiating a rejoin, was causing an error in next SyncGroup, that was causing the lost assignment.
on commit during a rebalance.
airlock-confluentinc
bot
force-pushed
the
dev_fix_assignment_lost_on_illegal_generation
branch
from
ca1e90f to
40dc10b
Compare
emasab
added a commit
to mfleming/librdkafka
that referenced
this pull request
Feb 18, 2025
emasab
added a commit
to mfleming/librdkafka
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4059.
Commits during a rebalance could cause to lose the assignment if the
generation id was bumped by second join group request.
Solved by not rejoining the group in case an illegal generation error happens
during a rebalance.
Happening since v1.6.0.
See this comment for the explanation of the issue:
#4059 (comment)