-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: support aarch64/arm64 build #2194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support build cloud-api-adaptor (except podvm) on aarch64/arm64 platform. Signed-off-by: Tao Xu <[email protected]> Reviewed-by: Seunguk Shin <[email protected]> Reviewed-by: Nick Connolly <[email protected]>
stevenhorsman
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to be. Thanks @xutao323 and team.
bpradipt
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @xutao323
Thanks @stevenhorsman @bpradipt for reviewing the changes. |
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Jan 13, 2025
When the arm support was added in confidential-containers#2194 it seems to have broken ppc64le builds: e.g. https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12747057891 so try and fix this Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Jan 17, 2025
When the arm support was added in confidential-containers#2194 it seems to have broken ppc64le builds: e.g. https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12747057891 so try and fix this Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Jan 17, 2025
When the arm support was added in confidential-containers#2194 it seems to have broken ppc64le builds: e.g. https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12747057891 so try and fix this Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
added a commit
that referenced
this pull request
Jan 17, 2025
When the arm support was added in #2194 it seems to have broken ppc64le builds: e.g. https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12747057891 so try and fix this Signed-off-by: stevenhorsman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support build cloud-api-adaptor (except podvm) on aarch64/arm64 platform, and it's tested on both x86_64 and aarch64 servers.
Podvm build support is excluded as it's recently changed from local build to ORAS cached artifacts to get guest-component in #2074. Will rebase with latest v0.11.0 changes later.
E2E test is able to run on aarch64/arm64 server with changes in #2193, plus operator's arm64 build and local built podvm (v0.9.0 and v0.10.0, and by packer and mkosi):