Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: support aarch64/arm64 build #2194

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

xutao323
Copy link
Contributor

@xutao323 xutao323 commented Dec 6, 2024

Support build cloud-api-adaptor (except podvm) on aarch64/arm64 platform, and it's tested on both x86_64 and aarch64 servers.

Podvm build support is excluded as it's recently changed from local build to ORAS cached artifacts to get guest-component in #2074. Will rebase with latest v0.11.0 changes later.

E2E test is able to run on aarch64/arm64 server with changes in #2193, plus operator's arm64 build and local built podvm (v0.9.0 and v0.10.0, and by packer and mkosi):

$ kubectl get pods -o wide
NAME             READY   STATUS    RESTARTS   AGE     IP           NODE                 NOMINATED NODE   READINESS GATES
busybox-remote   1/1     Running   0          6m16s   10.244.1.8   peer-pods-worker-0   <none>           <none>

$ kubectl exec pods/busybox-remote -- uname -srim
Linux 5.4.0-136-generic aarch64 unknown

$ kcli list vm
+-------------------------------+--------+-----------------+------------+-----------+---------+
|              Name             | Status |        Ip       |   Source   |    Plan   | Profile |
+-------------------------------+--------+-----------------+------------+-----------+---------+
|      peer-pods-ctlplane-0     |   up   |  192.168.122.20 | ubuntu2204 | peer-pods |  kvirt  |
|       peer-pods-worker-0      |   up   | 192.168.122.199 | ubuntu2204 | peer-pods |  kvirt  |
| podvm-busybox-remote-62291ece |   up   | 192.168.122.237 |            |           |         |
+-------------------------------+--------+-----------------+------------+-----------+---------+

$ virsh list
 Id   Name                            State
-----------------------------------------------
 70   peer-pods-ctlplane-0            running
 71   peer-pods-worker-0              running
 72   podvm-busybox-remote-62291ece   running 

Support build cloud-api-adaptor (except podvm) on aarch64/arm64 platform.

Signed-off-by: Tao Xu <[email protected]>
Reviewed-by: Seunguk Shin <[email protected]>
Reviewed-by: Nick Connolly <[email protected]>
@xutao323 xutao323 requested a review from a team as a code owner December 6, 2024 12:01
@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Dec 6, 2024
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to be. Thanks @xutao323 and team.

Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @xutao323

@bpradipt bpradipt merged commit 7c05ef0 into confidential-containers:main Dec 10, 2024
42 checks passed
@xutao323 xutao323 deleted the build_aarch64 branch December 10, 2024 11:05
@xutao323
Copy link
Contributor Author

Thanks @stevenhorsman @bpradipt for reviewing the changes.

stevenhorsman added a commit to stevenhorsman/cloud-api-adaptor that referenced this pull request Jan 13, 2025
When the arm support was added in confidential-containers#2194 it seems
to have broken ppc64le builds: e.g.
https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12747057891
so try and fix this

Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman added a commit to stevenhorsman/cloud-api-adaptor that referenced this pull request Jan 17, 2025
When the arm support was added in confidential-containers#2194 it seems
to have broken ppc64le builds: e.g.
https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12747057891
so try and fix this

Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman added a commit to stevenhorsman/cloud-api-adaptor that referenced this pull request Jan 17, 2025
When the arm support was added in confidential-containers#2194 it seems
to have broken ppc64le builds: e.g.
https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12747057891
so try and fix this

Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman added a commit that referenced this pull request Jan 17, 2025
When the arm support was added in #2194 it seems
to have broken ppc64le builds: e.g.
https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12747057891
so try and fix this

Signed-off-by: stevenhorsman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants