Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Migrator #4

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM migrators first at @conda-forge/arm-arch.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12608418960 - please use this URL for debugging.

@regro-cf-autotick-bot regro-cf-autotick-bot requested review from theAeon and a team as code owners January 4, 2025 07:08
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mfansler
Copy link
Member

mfansler commented Jan 6, 2025

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits January 6, 2025 13:37
@theAeon
Copy link
Contributor

theAeon commented Jan 7, 2025

is it a bug that scanning the cross-compile R makeconf gives the build_prefix link folder? probably. Is it one that is extremely easy to work around with a one line patch? Absolutely.

Merging.

@theAeon theAeon merged commit 02e5440 into conda-forge:main Jan 7, 2025
15 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the bot-pr_arch_h6211e7 branch January 7, 2025 01:42
@danielnachun
Copy link

It may be worth noting here that for linux-aarch64 and linux-ppc64le, it's also possible to set:

provider:
  linux_aarch64: azure
  linux_ppc64le: azure

without setting build_platform to be linux-64. This uses emulation with qemu to avoid needing to cross-compile. It's obviously slower but it does allow for native testing, and this R package doesn't take very long to build anyway. Unfortunately this isn't possible for osx-arm64, but I'm hoping Azure Pipelines will get around to native Apple Silicon support soon anyway.

@theAeon
Copy link
Contributor

theAeon commented Jan 7, 2025

For whatever its worth, I know it passes tests on aarch64 from running it myself on all 3 major OSes. Can't speak for PPC but I'm not all that worried about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants