-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dask_labextension v5.0.2, remove dependency on nodejs, more tests and maintainer #22
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please rerender |
…nda-forge-pinning 2021.06.02.13.20.38
@conda-forge/dask_labextension ready for review! |
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-webservice. |
@ian-r-rose @jacobtomlinson you probably have more insight. I can also add you to the maintainer list if you like. |
Happy to help! |
@conda-forge-admin please rerender |
…nda-forge-pinning 2021.06.03.12.21.11
Thanks for this @bollwyvl!
👍
I admit I'm still a little puzzled as to what best practices are between PEP 517/518 packaging and conda-forge packaging (especially for labextensions and
Thanks for this. Fixes dask/dask-labextension#191 |
Yeah, right? Honestly: I don't really know. It's a non-secret that i'm not a big fan of But wait, it's not just Probably at the end of the day, conda-build will have to start patching |
I'm happy with this if CI is happy, but if @ocefpaf has any thoughts around |
Sometimes it works as-is, sometimes the build dependencies listed there force us to delete it and let conda take care of the build. I agree with @bollwyvl, this is something that should be fixed in conda-build. Until then, we need the workaround in some places. |
Thanks @ocefpaf |
Thanks all!
|
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Thanks for maintaining this, folks!
This (sorta) simplifies the recipe:
nodejs
dependency altogetherpyproject.toml
--skip-npm
flagThen makes it more complicated:
plugin.json
gets gets deployed (my original issue)