Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asapdiscovery openfe pin #960

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Feb 14, 2025

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@mikemhenry mikemhenry requested a review from a team as a code owner February 14, 2025 17:33
@mikemhenry
Copy link
Contributor Author

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mikemhenry
Copy link
Contributor Author

Not sure why this is making an empty diff

@mikemhenry
Copy link
Contributor Author

mikemhenry commented Feb 14, 2025

They exist
image

Looking at the package, this is what is listed in the json:

"openfe >0.14.0*",

maybe the * is throwing things off? in the recipe it looks like this openfe =>0.14.0

@mikemhenry
Copy link
Contributor Author

That is exactly what it needed

@mikemhenry
Copy link
Contributor Author

================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
osx-arm64
osx-arm64::asapdiscovery-0.6.0-py310hbe9552e_0.conda
osx-arm64::asapdiscovery-0.6.0-py311h267d04e_0.conda
-    "openfe >0.14.0*",
+    "openfe =>1.1.0",
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
noarch
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
osx-64::asapdiscovery-0.6.0-py310h2ec42d9_0.conda
osx-64::asapdiscovery-0.6.0-py311h6eed73b_0.conda
-    "openfe >0.14.0*",
+    "openfe =>1.1.0",
================================================================================
================================================================================
linux-64
linux-64::asapdiscovery-0.6.0-py310hff52083_0.conda
linux-64::asapdiscovery-0.6.0-py311h38be061_0.conda
-    "openfe >0.14.0*",
+    "openfe =>1.1.0",

@mikemhenry
Copy link
Contributor Author

Ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants