Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch rubin-sim 2.2.0 for numpy 2 #955

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

beckermr
Copy link
Member

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

xref: conda-forge/rubin-sim-feedstock#59

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Thanks Matt! 🙏

It looks like PR ( conda-forge/rubin-sim-feedstock#59 ) is still open. Do you plan to merge that?

Recall we have usually made the fix in the latest build and repodata patched older ones

@beckermr
Copy link
Member Author

diff is correct

noarch::rubin-sim-2.2.0-pyhd8ed1ab_0.conda
-    "numpy",
+    "numpy >=2",

@beckermr beckermr added the automerge Merge the PR when CI passes label Jan 31, 2025
@conda-forge-admin conda-forge-admin merged commit f43ade7 into conda-forge:main Jan 31, 2025
3 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • github-actions: passed

Thus the PR was passing and merged! Have a great day!

@beckermr
Copy link
Member Author

I will leave the merging of that PR up to @rhiannonlynne. The next version of this package doesn't need the numpy >=2 constraint and so unless we need another build of 2.2.0, there is no reason to merge it.

@beckermr beckermr deleted the beckermr-patch-4 branch January 31, 2025 20:25
@jakirkham
Copy link
Member

Ok at least my understanding of why we add the pin to the recipe is in the event the same version of the package needs to be rebuilt for another reason. Having the pin there ensures we don't forget this constraint when addressing a different issue. Something that is especially helpful if there is time pressure

@beckermr
Copy link
Member Author

Right except that for the next version of the code, this pin will be wrong and we'll need to remove it again. IDK what is best to do here. It is a one-time case I think.

@jakirkham
Copy link
Member

It would be ok to drop it then

Would Grayskull pick up this change for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants