-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch rubin-sim 2.2.0 for numpy 2 #955
fix: patch rubin-sim 2.2.0 for numpy 2 #955
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks Matt! 🙏 It looks like PR ( conda-forge/rubin-sim-feedstock#59 ) is still open. Do you plan to merge that? Recall we have usually made the fix in the latest build and repodata patched older ones |
diff is correct
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
I will leave the merging of that PR up to @rhiannonlynne. The next version of this package doesn't need the numpy >=2 constraint and so unless we need another build of 2.2.0, there is no reason to merge it. |
Ok at least my understanding of why we add the pin to the recipe is in the event the same version of the package needs to be rebuilt for another reason. Having the pin there ensures we don't forget this constraint when addressing a different issue. Something that is especially helpful if there is time pressure |
Right except that for the next version of the code, this pin will be wrong and we'll need to remove it again. IDK what is best to do here. It is a one-time case I think. |
It would be ok to drop it then Would Grayskull pick up this change for you? |
Checklist
generate_patch_json.py
if absolutely necessary.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.xref: conda-forge/rubin-sim-feedstock#59