Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uxarray patch to fix python constraints #952

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Jan 25, 2025

These are needed for 2 recent versions, 2024.12.0 and 2025.01.0

See conda-forge/uxarray-feedstock#89

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

ping @conda-forge/uxarray

These are neede for 2 recent versions, 2024.12.0 and 2025.01.0

See conda-forge/uxarray-feedstock#89
@xylar xylar requested a review from a team as a code owner January 25, 2025 21:28
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xylar
Copy link
Contributor Author

xylar commented Jan 25, 2025

show_diff.py is showing the expected result:

$ ./show_diff.py                                  
================================================================================
================================================================================
linux-armv7l                                                                    
================================================================================
================================================================================
win-32
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
noarch
noarch::uxarray-2024.12.0-pyhd8ed1ab_0.conda
noarch::uxarray-2025.01.0-pyhd8ed1ab_0.conda
-    "python >=3.9",
+    "python >=3.10",
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
osx-arm64
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
================================================================================
================================================================================
linux-64

@xylar
Copy link
Contributor Author

xylar commented Jan 25, 2025

@conda-forge/core, I believe this is ready for review.

@ocefpaf ocefpaf merged commit fededc2 into conda-forge:main Jan 26, 2025
3 checks passed
@xylar xylar deleted the fix-uxarray-python-bounds branch January 26, 2025 17:29
@xylar
Copy link
Contributor Author

xylar commented Jan 26, 2025

@ocefpaf, thank you. Much appreciated!

@ocefpaf
Copy link
Member

ocefpaf commented Jan 26, 2025

Thank you, that was very likely my oversight in merging update PRs.

@xylar
Copy link
Contributor Author

xylar commented Jan 26, 2025

@ocefpaf, I think you're off the hook in this case and it's the uxarray maintainers that missed this. But it was an easy fix in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants