Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid py-lief 0.16 with current conda-build #946

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jan 16, 2025

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

C.f. conda-forge/conda-build-feedstock#239 & conda/conda-build#5594

>python show_diff.py
================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
osx-arm64::conda-build-25.1.1-py310hbe9552e_0.conda
osx-arm64::conda-build-25.1.1-py311h267d04e_0.conda
osx-arm64::conda-build-25.1.1-py312h81bd7bf_0.conda
osx-arm64::conda-build-25.1.1-py39h2804cbe_0.conda
-    "py-lief",
+    "py-lief <0.16.0a0",
================================================================================
================================================================================
linux-ppc64le
linux-ppc64le::conda-build-25.1.1-py310h194a6c8_0.conda
linux-ppc64le::conda-build-25.1.1-py311h1af927a_0.conda
linux-ppc64le::conda-build-25.1.1-py312h7864ebf_0.conda
linux-ppc64le::conda-build-25.1.1-py39h0b1cf3c_0.conda
-    "py-lief",
+    "py-lief <0.16.0a0",
================================================================================
================================================================================
linux-aarch64
linux-aarch64::conda-build-25.1.1-py310h4c7bcd0_0.conda
linux-aarch64::conda-build-25.1.1-py311hec3470c_0.conda
linux-aarch64::conda-build-25.1.1-py312h996f985_0.conda
linux-aarch64::conda-build-25.1.1-py39h4420490_0.conda
-    "py-lief",
+    "py-lief <0.16.0a0",
================================================================================
================================================================================
noarch
================================================================================
================================================================================
win-64
win-64::conda-build-25.1.1-py310h5588dad_0.conda
win-64::conda-build-25.1.1-py311h1ea47a8_0.conda
win-64::conda-build-25.1.1-py312h2e8e312_0.conda
win-64::conda-build-25.1.1-py39hcbf5309_0.conda
-    "py-lief",
+    "py-lief <0.16.0a0",
================================================================================
================================================================================
osx-64
osx-64::conda-build-25.1.1-py310h2ec42d9_0.conda
osx-64::conda-build-25.1.1-py311h6eed73b_0.conda
osx-64::conda-build-25.1.1-py312hb401068_0.conda
osx-64::conda-build-25.1.1-py39h6e9494a_0.conda
-    "py-lief",
+    "py-lief <0.16.0a0",
================================================================================
================================================================================
linux-64
linux-64::conda-build-25.1.1-py310hff52083_0.conda
linux-64::conda-build-25.1.1-py311h38be061_0.conda
linux-64::conda-build-25.1.1-py312h7900ff3_0.conda
linux-64::conda-build-25.1.1-py39hf3d152e_0.conda
-    "py-lief",
+    "py-lief <0.16.0a0",

@h-vetinari h-vetinari requested a review from a team as a code owner January 16, 2025 17:52
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@beckermr beckermr merged commit ef0b2ee into conda-forge:main Jan 16, 2025
3 checks passed
@tkelman
Copy link
Member

tkelman commented Jan 16, 2025

I think the upper bound on lief needs to be 0.15, this was missed osx test coverage on my fix for lief 0.15 rather than a new renaming in 0.16

@tkelman
Copy link
Member

tkelman commented Jan 16, 2025

What's the preferred workflow here, are these treated in an append-only manner or can that last line be edited? (or merged with the prior conda-build repodata patch even, since the lief requirement is the same and just the conda-build version_le should apply to the latest release)

@hmaarrfk
Copy link
Contributor

I think it can be edited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants