Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parcels: zarr<3 #939

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

VeckoTheGecko
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko commented Jan 10, 2025

conda-forge/parcels-feedstock#129 (comment)

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@VeckoTheGecko VeckoTheGecko requested a review from a team as a code owner January 10, 2025 12:52
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@VeckoTheGecko
Copy link
Contributor Author

@ocefpaf Is it an issue that this doesn't also target earlier versions of parcels? Or is it a necessary evil (i.e., that you cant retrospectively add upperbounds for everything as the software sphere moves forward).

@ocefpaf
Copy link
Member

ocefpaf commented Jan 10, 2025

@ocefpaf Is it an issue that this doesn't also target earlier versions of parcels? Or is it a necessary evil (i.e., that you cant retrospectively add upperbounds for everything as the software sphere moves forward).

This is kind of a choice of how much patching you want. IMO, patching the latest/most used version is essential, anything beyond that may be too much. Sure, those old version may be broken, but the promise of support is probably long gone, people who really need them can figure out how to downgrade zarr, etc.

@ocefpaf ocefpaf merged commit 152e3ec into conda-forge:main Jan 10, 2025
3 checks passed
@VeckoTheGecko VeckoTheGecko deleted the patch-parcels-zarr branch January 10, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants