Run build:ts in lint and lint:ci #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to typescript errors in the code base the tsc portion of build:ts is hardcoded to always return a 0 exit code.
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I'm confused as to why there are so many dtslint errors in CI. I cloned this repository into a new directory, did an npm install added the changes in this PR ran |
MysteryBlokHed
approved these changes
Jun 27, 2024
MysteryBlokHed
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to typescript errors in the code base the
tscportion ofbuild:tsis hardcoded to always return a 0 exit code.This should work on Linux and Mac (I only tested it on Linux). If we want to support building on Windows then we need a different strategy for the exit code. There are a number of npm packages that will handle the exit code in a cross platform manner. (e.g. https://github.com/kachkaev/suppress-exit-code).