-
Notifications
You must be signed in to change notification settings - Fork 6
README.md: Change the python file name #21
base: master
Are you sure you want to change the base?
Conversation
This fixes python file name and changes it from langserver-python.py --> coala-langserver.py Fixes #20
Travis tests have failedHey @he1l0world, 1st Build
TravisBuddy Request Identifier: 33ffb9e0-09a2-11e9-b041-03da4daed2ec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some recent Travis tests have also been failing for coala-ls in a similar fashion.
The change looks good enough and doesn't look like something that should affect the build.
@shashank-b Okay. Thanks. 👍 But I didn't see the README.md file change. |
@he1l0world, sorry, I didn't get you. Do you mean that the file didn't change in the master branch of coala? |
@shashank-b yeah it didn't change in the master branch of coala. |
I think it may be caused by #17 |
@gaocegege So, is there anything needs to be changed? |
Thanks, @gaocegege. It does seem to be the cause. |
Travis tests have failedHey @he1l0world, 1st Build
TravisBuddy Request Identifier: 87a28710-1250-11e9-962f-bf63ffca8115 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@he1l0world, Looks like since you were working on multiple issues from your master branch, we have some extra and unrequired changes in this PR now.
This is why working from the master branch is not advised. You would have to correct this issue as well.
@shashank-b Sorry, I didn't notice it will commit two different changes at same time. |
This fixes python file name and changes
it from langserver-python.py --> coala-langserver.py
Fixes #20