Added cancellable context #309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgannon991
force-pushed
the
feat/2234/cancel-context
branch
from
332b354 to
1debf88
Compare
dgannon991
force-pushed
the
feat/2234/cancel-context
branch
from
af409c3 to
abef8d6
Compare
Signed-off-by: David Gannon <[email protected]>
dgannon991
force-pushed
the
feat/2234/cancel-context
branch
from
abef8d6 to
4d9d6fd
Compare
dgannon991
changed the title
|
After feedback, I have made this a mandatory parameter to the action.Run and driver.Run methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using cnab-go in porter, we have a requirement to be able to cancel a long running task.
To this end, I've updated the Run method such that you can provide in a context and then I've updated the docker.exec method such that if the context is cancelled, it will attempt to stop the container.
This is just a suggestion, and one possible solution towards getporter/porter#2234, happy to take feedback and suggestions :)
Cheers!