Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:use different devtool #59

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

longshuicy
Copy link
Member

image

Thanks @robkooper @bodom0015! Might as well just tag you two for review :p

@lmarini
Copy link
Member

lmarini commented Jan 28, 2022

@longshuicy this doesn't seem to work for me. I see the new URLs, but when I click on them I still get directed to the minified file. I am doing this in the clowder debug window. Also is the # a typo? Even without it I am getting errors.

One more thing, if I read this page correctly https://webpack.js.org/configuration/devtool/ I think we might want to use eval-source-map for dev build and source-map for prod build. Still trying to understand the differences.

@longshuicy longshuicy changed the title use different devtool WIP:use different devtool Jan 28, 2022
@longshuicy
Copy link
Member Author

@longshuicy this doesn't seem to work for me. I see the new URLs, but when I click on them I still get directed to the minified file. I am doing this in the clowder debug window. Also is the # a typo? Even without it I am getting errors.

One more thing, if I read this page correctly https://webpack.js.org/configuration/devtool/ I think we might want to use eval-source-map for dev build and source-map for prod build. Still trying to understand the differences.

Yeah i tried a few things and couldn't make it work yet. Hold on to reivew/merge this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lmarini lmarini marked this pull request as draft March 9, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants