Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reannounce validation error in date range picker on apply #3210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abdhalees
Copy link
Member

@abdhalees abdhalees commented Jan 21, 2025

Description

When a user clicks on "Apply" in DateRangePicker, the error text should be reannounced

Related links, issue #, if available: AWSUI-60295

How has this been tested?

with voice over on, following the recording in the ticket

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (28012d5) to head (e7f109c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3210   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         789      789           
  Lines       22255    22253    -2     
  Branches     7636     7638    +2     
=======================================
- Hits        21459    21458    -1     
+ Misses        789      743   -46     
- Partials        7       52   +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdhalees abdhalees marked this pull request as ready for review January 21, 2025 17:20
@abdhalees abdhalees requested a review from a team as a code owner January 21, 2025 17:20
@abdhalees abdhalees requested review from at-susie, a team and jperals and removed request for a team and at-susie January 21, 2025 17:20
@jperals
Copy link
Member

jperals commented Jan 22, 2025

Could we have integ coverage for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants