Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bottom border to top navigation #3192

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cansuaa
Copy link
Contributor

@cansuaa cansuaa commented Jan 15, 2025

Description

Add bottom border to top navigation.

Issue: AWSUI-60155

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cansuaa cansuaa requested a review from a team as a code owner January 15, 2025 09:48
@cansuaa cansuaa requested review from just-boris and removed request for a team January 15, 2025 09:48
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (67c06fa) to head (7a3f008).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3192      +/-   ##
==========================================
+ Coverage   96.40%   96.42%   +0.01%     
==========================================
  Files         784      787       +3     
  Lines       22144    22195      +51     
  Branches     7191     7615     +424     
==========================================
+ Hits        21349    21401      +52     
+ Misses        788      742      -46     
- Partials        7       52      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

just-boris
just-boris previously approved these changes Jan 16, 2025
@cansuaa cansuaa changed the title feat: Add showBottomBorder API to top navigation feat: Add bottom border to top navigation Jan 20, 2025
@cansuaa cansuaa requested a review from just-boris January 20, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants