Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inline multiselect tokens #3185

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

katiegeorge
Copy link
Member

@katiegeorge katiegeorge commented Jan 13, 2025

Description

This moves inline tokens in multiselect out of beta and into a public feature.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (372abbd) to head (0fa964b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3185   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         787      787           
  Lines       22191    22191           
  Branches     7555     7614   +59     
=======================================
  Hits        21398    21398           
- Misses        741      786   +45     
+ Partials       52        7   -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katiegeorge katiegeorge changed the title Kg/inline multiselect tokens feat: Inline multiselect tokens Jan 13, 2025
@katiegeorge katiegeorge force-pushed the kg/inline-multiselect-tokens branch from ba1c57a to 02428ba Compare January 17, 2025 19:35
@katiegeorge katiegeorge marked this pull request as ready for review January 17, 2025 20:12
@katiegeorge katiegeorge requested a review from a team as a code owner January 17, 2025 20:12
@katiegeorge katiegeorge requested review from Al-Dani and removed request for a team January 17, 2025 20:12
Al-Dani
Al-Dani previously approved these changes Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants