Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Self-referring aria-labelledby #91

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

fralongo
Copy link
Member

Avoid infinite loop when the aria-labelledby points to the element itself. This happens, for example, in info links within container header.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fralongo fralongo requested a review from a team as a code owner August 26, 2024 08:32
@fralongo fralongo requested review from georgylobko and removed request for a team August 26, 2024 08:32
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.13%. Comparing base (acc9a5f) to head (d8afd8a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          26       26           
  Lines         579      580    +1     
  Branches      132      136    +4     
=======================================
+ Hits          574      575    +1     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fralongo fralongo added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit dc6d8c1 Aug 26, 2024
30 checks passed
@fralongo fralongo deleted the flongo-fix-self-reference branch August 26, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants