feat: Single tab stop util #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 13, 2025 14:00
katiegeorge
requested review from
YueyingLu and
pan-kot
and removed request for
a team and
YueyingLu
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 99.23% 99.30% +0.07%
==========================================
Files 27 29 +2
Lines 652 720 +68
Branches 173 193 +20
==========================================
+ Hits 647 715 +68
Misses 5 5 ☔ View full report in Codecov by Sentry. |
pan-kot
force-pushed
the
kg/single-tab-stop-simple
branch
from
5114cbc to
72aa996
Compare
pan-kot
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This moves the util of single tab stop out of
componentsand into the toolkit repository.It also moves the following utils, necessary for keyboard navigation:
node-belongsfocus-lock-utilshandle-keycircle-indexBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.