feat: Report metric errors #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Jan 10, 2025
| console.error(message); | ||
| const panorama = this.findPanorama(window); | ||
| if (panorama) { | ||
| panorama('trackCustomEvent', { |
There was a problem hiding this comment.
Theoretically, this could be a this.sendMetric() call. But I decided to avoid recursion for safety and call the panorama function directly.
Safety > code reuse
just-boris
force-pushed
the
error-metrics
branch
from
2ddc01b to
6bbb44b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage 99.22% 99.23%
=======================================
Files 27 27
Lines 647 652 +5
Branches 169 176 +7
=======================================
+ Hits 642 647 +5
Misses 5 5 ☔ View full report in Codecov by Sentry. |
abdhalees
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently, if there are issues with metrics, we simply drop it. With this change, we will report an error message instead, which we can investigate
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.