chore: Try sending metrics to panorama before clog API #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Jan 6, 2025
| @@ -91,28 +97,26 @@ export class PanoramaClient { | |||
| } | |||
| if (!validateLength(metric.eventName, 1000)) { | |||
| console.error(`Event name for metric is too long: ${metric.eventName}`); | |||
| return; | |||
| return true; | |||
There was a problem hiding this comment.
Validation constraints are same for both API, return true to prevent it from attempting to use AWSC.Clog.log if the validation fails
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 27 27
Lines 644 647 +3
Branches 175 175
=======================================
+ Hits 639 642 +3
Misses 5 5 ☔ View full report in Codecov by Sentry. |
abdhalees
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Before: try finding
AWSC.Clog.logAPI first, thenpanoramaAfter: try
panoramaAPI first, thenAWSC.Clog.log.Part of the plan to eventually remove
AWSC.Clog.logfrom our code after confirming thepanoramaAPI collects all dataBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.