Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Mark package as side effects free #108

Merged
merged 1 commit into from
Jan 6, 2025
Merged

chore: Mark package as side effects free #108

merged 1 commit into from
Jan 6, 2025

Conversation

just-boris
Copy link
Member

Issue #, if available:

Description of changes:

By default, bundlers are conservative and consider Symbol.for(...) call as a side effect and leave it in the bundle even if unused:

https://github.com/cloudscape-design/component-toolkit/blob/d5f68a152bf6f5f4226bc983d2c7d341600f5e0e/src/internal/global-flags/index.ts#L4C39-L4C78

Let's help them with a declaration

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner December 27, 2024 13:30
@just-boris just-boris requested review from YueyingLu and removed request for a team December 27, 2024 13:30
@just-boris just-boris marked this pull request as draft December 27, 2024 13:30
@just-boris just-boris removed the request for review from YueyingLu December 27, 2024 13:30
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (d5f68a1) to head (7e15ded).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          27       27           
  Lines         644      644           
  Branches      172      172           
=======================================
  Hits          639      639           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris requested review from a team and cansuaa and removed request for a team and cansuaa December 27, 2024 14:39
@just-boris just-boris marked this pull request as ready for review January 3, 2025 21:45
@just-boris just-boris requested a review from YueyingLu January 3, 2025 21:45
@just-boris just-boris added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 57d049f Jan 6, 2025
37 checks passed
@just-boris just-boris deleted the side-effects branch January 6, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants