fix: Always provide firstIndex and totalItemsCount in collection result #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 443 443
Branches 156 156
=========================================
Hits 443 443 ☔ View full report in Codecov by Sentry. |
pan-kot
requested review from
cansuaa and
gethinwebster
and removed request for
a team
gethinwebster
approved these changes
Apr 17, 2024
Checked for the possible impact - no failed packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
firstIndexandtotalItemsCountproperties are used in the Table and Cards components. The properties are needed forrenderAriaLiveannouncements and to assignaria-rowcountandaria-rowindex. While the latter can be omitted when there is no pagination, the live announcements are important regardless because those include the change of the total items count when filtering.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.