Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS settings #3670

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Conversation

Cyb3r-Jak3
Copy link
Contributor

Description

Adds new Settings field to DNSRecord. Only has CNAME Flattening currently.

Has your change been tested?

Add new test and it passes

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@Cyb3r-Jak3
Copy link
Contributor Author

Copy link
Contributor

changelog detected ✅

@jacobbednarz
Copy link
Member

cc @janik-cloudflare

@janik-cloudflare
Copy link
Member

Nice one, thanks. I don't know if you all want to merge this given that auto-generation is on the way, but no objections from my side.

@jacobbednarz
Copy link
Member

jacobbednarz commented Jan 20, 2025

we'll land it here for v0 however, v4 is soon to be the default so this won't be used in the terraform provider.

@jacobbednarz jacobbednarz merged commit cbf5d7e into cloudflare:master Jan 20, 2025
6 of 7 checks passed
@github-actions github-actions bot added this to the v0.115.0 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants