Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #331: sexpr on tagged literal should be fully qualified #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

borkdude
Copy link
Collaborator

No description provided.

@lread
Copy link
Collaborator

lread commented Jan 31, 2025

Hmmmm... Seems to break cljs tests... and also zprint and umschreiben-clj.

@borkdude
Copy link
Collaborator Author

The test in umschreiben fails exactly because they depend on the unqualified symbol right now
The CLJS tests might fail because clojure.core/read-string or cljs.core/read-string doesn't exist. Should we emit clojure.edn/read-string instead? 🤔

@lread
Copy link
Collaborator

lread commented Jan 31, 2025

Kinda feels sort similar in spirit to #305? zprint had some problems with that one too kkinnear/zprint#333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants