Basic localization abilities #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,9 @@ var webSocket = require('ws'); | |||
| var channel = '#atp'; | |||
| var webAddress = 'http://www.caseyliss.com/showbot'; | |||
| var TITLE_LIMIT = 75; | |||
| var BOT_LANG = 'en'; | |||
There was a problem hiding this comment.
Maybe instead of hardcoding the language here, you get it from Accept-Language? That way you could serve up different languages to different users from the same running instance depending on their language settings for their browser.
There was a problem hiding this comment.
I haven't tried yet, but does the Accept-Language propagate through IRC?
This little hack of mine only applies to the bot part, not to the web interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just started using the accidentalbot for an Italian podcast, and I translated it.
So, I thought I would share my localization "system". I also attached the Italian translation.