Add the localize function for the type UI.
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finish. Thanks for your careful review. |
|
Maybe we need to release a new version so that we can install it for vscode-clangd and coc-clangd? |
Yes, makes sense. Please feel free to create a PR which bumps the version in package.json. |
This was referenced Jan 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am implementing l10n support in vscode-clangd. However, I discovered that we are unable to localize the messages sent by node-clang. Thanks to @HighCommander4 suggestion, I have now add the "localize" function for the type UI. This function allows us to localize the messages sent by node-clang.
I will add the localize impl for coc-clangd, after the npm package is published,
Refer: clangd/vscode-clangd#560 (comment)