riverlea - consistent button alignment for menu and button cols

[ufundo]

Overview

Fix inconsistent alignment of button in different search kit column types.

Before

• buttons in menu and button columns are out of line:
  

[Manage Contribution page with 5.80.1 AdminUI + Standalone 5.80.1 / Riverlea / Thames (+ custom crm-c-primary)]

After

• buttons align:
  

Comments

I'm afraid I haven't tested lots of variations, but it makes sense these columns should get the same rules?

cc @vingle

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[ufundo]

You can see the issue on dmaster: https://dmaster.demo.civicrm.org/civicrm/admin/contribute?reset=1
And fixed on the test site: http://core-31728-5zven.test-1.civicrm.org:8003/civicrm/admin/contribute?reset=1

[vingle]

Thanks @ufundo. I can see three problems here:

• the one you spotted. your fix solves this instance, but the better method would be just to remove right and bottom margin from buttons - it's a hacky way of providing padding between multiple buttons that applies even when there's one button, whereas flex and gap would be consistent and wouldn't have weird effects like this one. But that's a bigger fix that needs some kind of targetable wrapper for multiple buttons, so best stick with your fix for now.
• nevertheless td.crm-search-col-type-buttons is set to flex but the other cells aren't which top aligns one button - this is still the case on your fix at certain viewports:

• there's uneven padding on these button groups (not really related but needs fixing).