Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Ensure that Privacy (single checkbox) fields show up on Event R… #31692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Jan 2, 2025

…egistrations when fields are used in a profile

Overview

This modifies the UFFields templates to only handle Radios and Checkboxes fields here if the field is not type boolean. This seems to fix the problem @jmcclelland identified in this PR #30992.

Before

Checkboxes don't show up when privacy fields included on event registrations

After

Checkboxes for privacy fields show up correctly

ping @andrew-cormick-dockery

Copy link

civibot bot commented Jan 2, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@colemanw
Copy link
Member

colemanw commented Jan 2, 2025

@seamuslee001 .entityType.php files do not support proprietary quickform elements like "advcheckbox". The translation from standard element types (CheckBox) to quickform-specific types (advcheckbox) should be done in the form layer.

@colemanw colemanw marked this pull request as draft January 2, 2025 11:43
…egistrations when fields are used in a profile
@seamuslee001 seamuslee001 marked this pull request as ready for review January 2, 2025 20:52
@seamuslee001 seamuslee001 force-pushed the privacy_profile_fields branch from 23cf771 to 58c2ed4 Compare January 2, 2025 20:52
@seamuslee001
Copy link
Contributor Author

@colemanw ok I think i have it sorted correctly now then I think the UFGroup code was correctly adding advcheckboxes here but the template was being a bit silly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants