Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorize slerp and remove custom code for create_group #8

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

chrisflesher
Copy link
Owner

@chrisflesher chrisflesher commented Jun 6, 2024

This makes two changes:

  1. Move business logic contained in the Slerp class to _slerp function
  2. Remove the business logic for create_group, let scipy handle this

This has the following benefits:

  1. Code is simpler
  2. Slerp can handle time input with any number of dimensions
  3. Allow option to use a plain slerp function instead of a class if desired

@chrisflesher chrisflesher force-pushed the vectorize_slerp branch 3 times, most recently from 1558f9d to f869ed6 Compare June 6, 2024 13:38
@chrisflesher chrisflesher merged commit 40073f3 into main Jun 6, 2024
1 check passed
@chrisflesher chrisflesher deleted the vectorize_slerp branch June 6, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant