Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix tailwind config #26

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: fix tailwind config #26

wants to merge 2 commits into from

Conversation

JaneMoroz
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@JaneMoroz JaneMoroz requested a review from Dan-Y-Ko as a code owner February 6, 2025 13:43
@Dan-Y-Ko
Copy link
Collaborator

Dan-Y-Ko commented Feb 6, 2025

@JaneMoroz this doesn't fix the issue we have. The dashboard repo isn't supposed to have all those tailwind styles, they need to be removed. When you do that, you can see the issue is that the theme isn't being exported from the package properly. I wrote awhile ago that switching the imports of the css fixed the layout issue but then the themes wasn't working, but I might have found a fix for that too. Please take a look at the branch fix/theme-config and change the things in the dashboard repo with what I mentioned in discord. It seems to be working after making those changes

@JaneMoroz
Copy link
Contributor Author

@JaneMoroz this doesn't fix the issue we have. The dashboard repo isn't supposed to have all those tailwind styles, they need to be removed. When you do that, you can see the issue is that the theme isn't being exported from the package properly. I wrote awhile ago that switching the imports of the css fixed the layout issue but then the themes wasn't working, but I might have found a fix for that too. Please take a look at the branch fix/theme-config and change the things in the dashboard repo with what I mentioned in discord. It seems to be working after making those changes

Okay, I added everything you mentioned to the dashboard project, and your fix works! But I don't see any theme issues🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants