Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #82. Under Android a channel must be "protected", i.e. marked as being already handled by a VPNService, otherwise a loop would result also redirecting the network traffic to the VPNService again. I created this hook to be able to get access for this and possibly other requirements in a generic way. Under Android
setOnConnectHandler
would be called and from the NettyChannel
the channel id could be cast to a socket integer.Questions:
a) Is the logic really called first after the channel is created, so that any VpnService cannot handle the channel again?
b) Is this the best approach?