Bugfix: TypeError in Interaction due to out-of-bounds index #11991
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have introduced a bug in my previous pull request #11986. This PR fixes it and adds 4 test cases to make sure it doesn't happen again.
If there is a line chart with the following dataset
and user hovers close to
2, thenbinarySearchwrapper returnshi: 4for nearest interaction, which is an index not existing in the dataset (it only has 3 elements). AnUncaught TypeErroris thrown at core.interaction.js:82.I apologize for not being diligent enough and introducing this error. The
end - 1was needed inhelpers.extras.ts, because+ 1is added to it in line 119 (to the left in screenshot below), but incore.interaction.jsit was not needed, because+ 1is not added to theresult(to the right in screenshot below).