-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scx-git: init; scx: remove #910
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Thank you for contributing to nyx! Please run |
e245a9a
to
7227eda
Compare
Everything above builds at the moment, and technically this is ready for merging. But I would like to wait until some merged PRs on Nixpkgs is available on unstable. |
Work is pretty much done ^^ except for the above changes which depend on nixpkgs bump. PRs to track:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
If this does not work I am done with fixing the CI. I have no clue where the problem lies my gosh. |
Oops! Something went wrong while caching this PR! Check the logs for more information. |
201f464
to
bf1d035
Compare
@PedroHLC can we get this reviewed :) |
Move bpftools-full out to its own file
Hello maintainers, just a reminder to inform users about updating their configurations to use scx_git.full instead of the default pkgs.scx. It's also recommended to set a correct default value that aligns with scx_git.full, as the previous default (pkgs.scx) may lead to unexpected issues. |
Exactly, here's what I am doing currently: { pkgs, ... }:
{
environment.systemPackages = with pkgs; [ scx ];
# --- New Configuration ---
chaotic.scx = {
enable = true;
package = pkgs.scx;
# one of "scx_bpfland", "scx_central", "scx_flatcg", "scx_lavd", "scx_layered", "scx_nest", "scx_pair", "scx_qmap", "scx_rlfifo", "scx_rustland", "scx_rusty", "scx_simple", "scx_userland"
scheduler = "scx_bpfland";
};
} |
Yup, PRs welcomed. Line 14 in 09f0dcf
https://github.com/NixOS/nixpkgs/blob/1f6ff249fe86a678965436f4d3c9c4a7e5601562/nixos/modules/services/scheduling/scx.nix#L23-L36 And we can remove the module entirely from here once the upstream PR is merged. |
🐟 What?
🎣 Why?
Scx is now available on Nixpkgs (stable version). So it makes sense to replace with the git version here.
🍥 Pending
After this is done, we will need to announce to the users asking to change their packages to
scx_git.full
. If they want to use the nixpkgs version, they should switch toscx.full
.🐳 Extras
I will recommend merging this after these PR reach unstable.