[archivist] Allow defining block time in settings for archivist #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
requested changes
Feb 12, 2025
| @@ -34,7 +34,7 @@ | |||
|
|
|||
|
|
|||
| MAX_EVENTS_PER_JOB = 5000 | |||
| BLOCK_TIMEOUT = 60000 # seconds | |||
| BLOCK_TIMEOUT = 60000 # milliseconds | |||
There was a problem hiding this comment.
This should be part of the settings and not part of this module.
jjmerchante
force-pushed
the
archivist-block
branch
2 times, most recently
from
5137003 to
8ef1da7
Compare
This commit allows defining the block time for reading items from the stream in archivist jobs when no more items are available for insertion into the database. This enables faster item insertion into storage but may cause the job to finish earlier. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
archivist-block
branch
from
8ef1da7 to
7ded4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows defining the block time for reading items from the stream in archivist jobs when no more items are available for insertion into the database.
This enables faster item insertion into storage but may cause the job to finish earlier.