Archive events in OpenSearch #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjmerchante
force-pushed
the
archive-opensearch
branch
2 times, most recently
from
439efdd to
d4b08fa
Compare
sduenas
requested changes
Jan 27, 2025
| @click.option('--workers', | ||
| default=10, | ||
| show_default=True, | ||
| help="Number of workers to run in the pool.") | ||
| def eventizers(workers: int): | ||
| """Start a pool of eventizer workers. | ||
| def worker_pool(task_types: str, workers: int): |
There was a problem hiding this comment.
I think we should keep eventizers command and create a new one (maybe archivists) to store the data (in this case on OpenSearch). I know your proposal it's more generic but the other one gives us more flexibility in terms of configuration and usability because users will know what to run.
| """Test if events are stored correctly""" | ||
|
|
||
| # Add some sample events to the stream | ||
| events = [ |
There was a problem hiding this comment.
I would say to rename events to expected_events, so it's clear later to understand what's going on.
| self.assertEqual(result.consumer_name, 'consumer_1') | ||
| self.assertEqual(result.total, len(events)) | ||
|
|
||
| result_events = MockStorageBackend.get_events() |
There was a problem hiding this comment.
And we can also rename these ones to stored_events.
jjmerchante
force-pushed
the
archive-opensearch
branch
4 times, most recently
from
b1f500d to
2d03da4
Compare
This commit implements archiving of events in an OpenSearch backend. It introduces a new subscriber group that reads from the events stream and stores events in an OpenSearch instance. Additionally, the worker pool now supports execution on specific task queues, enabling different workers to process tasks based on their queue. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
archive-opensearch
branch
from
2d03da4 to
cc3dd1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the archiving of events in an OpenSearch backend.
It introduces a new subscriber group that reads from the events stream and stores events in an OpenSearch instance.
Additionally, the worker pool now supports execution on specific task queues, enabling different workers to process tasks based on their queue.