28 change seek help page + styling #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arfamomin
force-pushed
the
28-change-seek-help-page-+-styling
branch
from
5af7ecf to
7ea16f3
Compare
philipye314
reviewed
Dec 7, 2024
Comment on lines
+103
to
+121
| <View style={styles.selectJurisdictionContainer}> | ||
| {jurisdiction.map(level => ( | ||
| <TouchableOpacity | ||
| key={level} | ||
| style={styles.checkButtonContainer} | ||
| onPress={() => toggleSelection(level)} | ||
| > | ||
| <View | ||
| style={[ | ||
| styles.checkButton, | ||
| selectedJurisdiction.includes(level) | ||
| ? styles.selectedCheckButton | ||
| : null, | ||
| ]} | ||
| > | ||
| {selectedJurisdiction.includes(level) && <Check />} | ||
| </View> | ||
| <Text style={styles.buttonText}>{level}</Text> | ||
| </TouchableOpacity> |
There was a problem hiding this comment.
I changed it for you - but I basically swapped the inner view and touchable opacity. generally we want buttons to take up as much space as possible in the container such that things are more clickable (and thereby accessible) - this is why I try and refrain from using margins and normally use padding! You can see that adding padding or simply swapping react components around can make the clickable area a lot bigger and more intuitive to use.
philipye314
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Screenshots
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @philipye314