fix chuckpacker y bug #4639
Open
fix chuckpacker y bug #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
everyone point and laugh at this user for introducing this bug |
|
Did GitHub miss a usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yinpackis already normalized to 0 - 384 andgetPathingBlockTypewas trying to normalize it again, causingadjYto be offset 64 blocks, which caused an oobe in the call toBlockStateInterface.getFromChunk.The exception got caught but the result seems to be that special blocks close to the build limit didn't get cached.
This probably also broke the caching of water.