Fix wrong termios save code #239
Conversation
This bug is introduced by 20e0658. Saving a *unix.Termios and then modifying it in SetRaw() makes the saved state useless. By restoring saveTermios type from *unix.Termios to unix.Termios, SetRaw() no longer influences the saved termios. This should fix c-bata#228 and c-bata#233 . Signed-off-by: Xiami <[email protected]>
|
I can confirm that this fixes the issue for me
|
|
+1 |
|
Is this merge request being looked at (or perhaps there is another preferred method to reset the prompts)? |
|
@c-bata the latest release is largely unusable due to this issue, it would be great if you could take a look at this simple fix please! |
|
Confirmed that this works 👍 |
|
@c-bata is there anybody out there are you okay |
|
Ok |
|
Great, thanks for catching the pointer issue where the original term state is overwritten when converting the terminal to raw mode because the code is passing around a pointer. I confirmed the commit fixes the bug and look forward to this being merged in to this fantastic library! |
|
Hi, I like this library but this issue is super annoying. Can this be merged ?? |
we've been waiting for a long time, I'd recommend just forking it and changing the mod path. that's what I've done and I imagine many others have done as well. |
|
Hi, could this please be merged @c-bata |
apply c-bata/go-prompt c-bata#239
|
ping |
just fork it or use an existing fork ong we just gotta pray that the homie C-13ata didn't die on us - it's been nearly a year free that mf out the 13ox - they dindu nuffin |
|
@c-bata please merge this PR. This is very useful repository and I wish to see it progress further. If you are not interested in maintaining this project please mention that in README.md Someone might step in to maintain it. この PR をマージしてください。これは非常に便利なリポジトリなので、さらに発展することを期待しています。このプロジェクトの保守に興味がない場合は、誰かがプロジェクトの保守に介入する可能性があることを README.md に記載してください。 |
|
ping on this - any updates? |
Ref: - c-bata#233 - c-bata#239
This bug is introduced by 20e0658.
Saving a *unix.Termios and then modifying it in SetRaw() makes the
saved state useless.
By restoring saveTermios type from *unix.Termios to unix.Termios,
SetRaw() no longer influences the saved termios.
This should fix #228 and #233 .
Signed-off-by: Xiami [email protected]