Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 6.0 #159

Merged
merged 11 commits into from
Mar 19, 2016
Merged

Version 6.0 #159

merged 11 commits into from
Mar 19, 2016

Conversation

bvaughn
Copy link
Owner

@bvaughn bvaughn commented Mar 17, 2016

Completed

  • Removed arrow-key snapping behavior from Grid and moved it into a new ArrowKeyStepper HOC; resolves VirtualScroll takes over arrow keys #156.
  • Removed scroll-to-* and set-scroll-* methods from FlexTable, Grid, and VirtualScroll; properties should be used instead of these methods.
  • Replaced react-pure-render with shallowCompare.

Resolves #156

@bvaughn bvaughn mentioned this pull request Mar 17, 2016
Closed
@jquense
Copy link
Contributor

jquense commented Mar 17, 2016

this is sweet!

@bvaughn bvaughn changed the title Removed arrow-key snapping behavior from Grid and moved it into a new ArrowKeyStepper HOC Version 6.0 Mar 18, 2016
bvaughn added a commit that referenced this pull request Mar 19, 2016
@bvaughn
Merge pull request #159 from /issues/156
35ad0c0 
Version 6.0
@bvaughn bvaughn merged commit 35ad0c0 into master Mar 19, 2016
@bvaughn bvaughn deleted the issues/156 branch March 19, 2016 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VirtualScroll takes over arrow keys
2 participants
@bvaughn @jquense