BOPZ scrapper v1 #49
Merged
BOPZ scrapper v1 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukosabino
reviewed
Jan 29, 2024
src/etls/bopz/metadata.py
Outdated
| from src.etls.common.metadata import MetadataDocument | ||
|
|
||
|
|
||
| class BOPZMetadataReferencia(BaseModel): |
There was a problem hiding this comment.
Remove this class.
It is not used, right?
src/etls/bopz/scrapper.py
Outdated
| return id_links | ||
|
|
||
| class BOPZScrapper(BaseScrapper): | ||
| BASE_URL = 'http://bop.dpz.es/BOPZ' |
There was a problem hiding this comment.
We should use lowercase for class variable.
src/etls/bopz/scrapper.py
Outdated
| initialize_logging() | ||
|
|
||
| # POST data to filter retrieved BOPZ documents | ||
| data_post = { |
There was a problem hiding this comment.
Use uppercase for global variable. Also, you can port this dict to a utils.py file.
src/etls/bopz/scrapper.py
Outdated
|
|
||
| return metadata_dict | ||
|
|
||
| def _list_links_day(url: str, day: date) -> tp.List[str]: |
There was a problem hiding this comment.
Right?
Suggested change
| def _list_links_day(url: str, day: date) -> tp.List[str]: | |
| def _list_links_day(url: str, day: date) -> tp.List[BeautifulSoup]: |
|
Modifica el fichero requirements.txt con todo lo que necesites. |
Co-authored-by: Darío López Padial <[email protected]>
Removido OCR
Incluido url_html en los metadatos
Cambios sugeridos
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| logger.info("Scrapping day: %s", day_str) | ||
| DATA_POST['fechaPubInf'] = day_str | ||
| DATA_POST['fechaPubSup'] = day_str | ||
| response = requests.post(url, data=DATA_POST) |
Check warning
Code scanning / Bandit
Call to requests without timeout Warning
| """ | ||
| logger = lg.getLogger(self.download_document.__name__) | ||
| logger.info("Scrapping document: %s", url) | ||
| response = requests.get(url) |
Check warning
Code scanning / Bandit
Requests call without timeout Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOPZ scraper v1:
Cambios específicos de este scrapper
Pruebas
Requisitos
from langchain_community.document_loaders import UnstructuredPDFLoaderPara ello es necesario: