Hybrid of a11y tree & DOM for input to observe #459
Conversation
🦋 Changeset detectedLatest commit: 5a7bd49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
seanmcguire12
requested review from
miguelg719 and
kamath
and removed request for
miguelg719
lib/a11y/utils.ts
Outdated
| parentId: node.parentId, | ||
| childIds: node.childIds, | ||
| xpath: node.xpath, |
There was a problem hiding this comment.
for large websites it makes sense to compute the xpaths at runtime for the candidates selected by observe
There was a problem hiding this comment.
yeah nice catch, we arent precomputing them, i'll take them out of the AXNode type since they are unused
| @@ -99,6 +107,10 @@ export function buildHierarchicalTree(nodes: AccessibilityNode[]): TreeResult { | |||
| ...(hasValidName && { name: node.name }), // Only include name if it exists and isn't empty | |||
| ...(node.description && { description: node.description }), | |||
| ...(node.value && { value: node.value }), | |||
| ...(node.backendDOMNodeId !== undefined && { | |||
There was a problem hiding this comment.
isnt backendDOMNodeId === nodeId?
There was a problem hiding this comment.
no, nodeId is a11y specific (remember we used to have negative values for nodeIds)
lib/a11y/utils.ts
Outdated
| level: 1, | ||
| }); | ||
|
|
||
| // fs.writeFileSync("../hybrid_tree.txt", hierarchicalTree.simplified); |
There was a problem hiding this comment.
| // fs.writeFileSync("../hybrid_tree.txt", hierarchicalTree.simplified); |
why
rolefor anAXNodeis something useless likenoneorgeneric. this isn't very helpful context for the LLMwhat changed
rolefor anAXNodeisnoneorgeneric, we replace it with thetagNameof its corresponding DOM elementbefore this PR:
after this PR: