Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moo: distinct-digits rule was not followed #933

Merged
merged 1 commit into from
Jan 27, 2025
Merged

moo: distinct-digits rule was not followed #933

merged 1 commit into from
Jan 27, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 27, 2025

  • In debugging I discovered the numbers 8182 and 4594 were being treated as valid
  • The unix version of moo selects a number where each digit occurs only once in the number [1]
  • A guess containing non-unique digits is not a valid guess [2]
  • Add a function to check for duplicate digits in guess
  • Rewrite secret number generator with shuffle() to guarantee unique digits
  1. http://squoze.net/UNIX/v6man/man6/moo.pdf
  2. https://github.com/hansklav/MOO

@mknos
moo: distinct-digits rule was not followed
df72a46 
* The unix version of moo selects a number where each digit occurs only once in the number [1]
* A guess containing non-unique digits is not a valid guess [2]
* Add a function to check for duplicate digits in guess
* Rewrite secret number generator with shuffle() to guarantee unique digits


1. http://squoze.net/UNIX/v6man/man6/moo.pdf
2. https://github.com/hansklav/MOO
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: moo The moo program labels Jan 27, 2025
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 27, 2025 12:02 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 27, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12988488044

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.389%
Totals Coverage Status
Change from base Build 12985937326: -0.7%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy self-assigned this Jan 27, 2025
@briandfoy briandfoy merged commit 5c0679f into briandfoy:master Jan 27, 2025
21 of 23 checks passed
@briandfoy
Copy link
Owner

changes: enforce the distinct digits rule

@briandfoy briandfoy added Type: bug an existing feature does not work Status: accepted The fix is accepted and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Jan 27, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: moo The moo program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy