Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: honour -s flag for w & e commands #931

Merged
merged 1 commit into from
Jan 24, 2025
Merged

ed: honour -s flag for w & e commands #931

merged 1 commit into from
Jan 24, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 24, 2025 •
edited
Loading

  • In BSD ed, the -s flag is for running an ed script
  • Modified buffers don't prevent the editor from quitting or editing a new file in this mode
  • GNU ed doesn't seem to follow this, but to me the GNU interpretation seems inconsistent with the meaning of -s

@mknos
ed: honour -s flag for w & e commands
b3cc33c 
* In BSD ed, the -s flag is for running an ed script
* Modified buffers don't prevent the editor from quitting or editing a new file in this mode
* GNU ed doesn't seem to follow this, but to me the GNU interpretation seems inconsistent with the meaning of -s
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jan 24, 2025
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 24, 2025 05:33 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12943903437

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.389%
Totals Coverage Status
Change from base Build 12931840510: -0.7%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy merged commit 28dcd04 into briandfoy:master Jan 24, 2025
21 of 23 checks passed
@briandfoy
Copy link
Owner

changes: honour -s flag for w & e commands

@briandfoy briandfoy removed the Priority: low get to this whenever label Jan 24, 2025
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jan 24, 2025
@briandfoy briandfoy self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy