Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

od: support more output formats with -t #928

Merged
merged 2 commits into from
Jan 23, 2025
Merged

od: support more output formats with -t #928

merged 2 commits into from
Jan 23, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 22, 2025

  • Add other integer format options (u1,u2,u4,d1,d2,d4,o1,o2,o4), as well as the aliases for options -a and -c
  • 8-byte integer formats could be added in future (these are supported by GNU version)
  • Make more of an effort to align output for -a and -c modes

@mknos
od: support more output formats with -t
c3cd548 
* Add other integer format options (u1,u2,u4,d1,d2,d4,o1,o2,o4) as well as the aliases for options -a and -c
* 8-byte integer formats could be added in future (these are supported by GNU version)
* Make more of an effort to align output for -a and -c modes
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: od The od program labels Jan 22, 2025
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 22, 2025 01:46 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 22, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12920610472

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.389%
Totals Coverage Status
Change from base Build 12889419996: -0.7%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

briandfoy
briandfoy requested changes Jan 22, 2025
View reviewed changes
bin/od Show resolved Hide resolved
@briandfoy briandfoy self-assigned this Jan 22, 2025
@briandfoy briandfoy added the Status: changes requested adjust the pull request as noted in comments label Jan 22, 2025
@mknos
sign fix in decimal1()
cdb391c 
* Use the correct unpack format "c" for signed char
* Add a comment to clarify why some ascii character names have an embedded space
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 23, 2025 01:48 — with GitHub Actions Inactive
@briandfoy briandfoy removed the Status: changes requested adjust the pull request as noted in comments label Jan 23, 2025
@briandfoy briandfoy merged commit 9ca0927 into briandfoy:master Jan 23, 2025
20 of 22 checks passed
@briandfoy
Copy link
Owner

changes: add other integer format options (u1,u2,u4,d1,d2,d4,o1,o2,o4), as well as the aliases for options -a and -c

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: od The od program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy