Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

od: support 1-byte hex format #927

Merged
merged 1 commit into from
Jan 21, 2025
Merged

od: support 1-byte hex format #927

merged 1 commit into from
Jan 21, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 21, 2025

  • od is expected to support a -t option for specifying output formats that don't exist as a single letter option
  • 2- and 4-byte hex output is possible without -t, but "-t x1" is the normal way to request 1-byte hex
  • Other format specifiers can be added to -t later, but for now add x1, x2 and x4
  • Update pod and usage string

@mknos
od: support 1-byte hex format
31c8871 
* od is expected to support a -t option for specifying output formats that don't exist as a single letter option
* 2- and 4-byte hex output is possible without -t, but "-t x1" is the normal way to request 1-byte hex
* Other format specifiers can be added to -t later, but for now add x1, x2 and x4
* Update pod and usage string
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: od The od program labels Jan 21, 2025
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 12:24 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12886858352

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.389%
Totals Coverage Status
Change from base Build 12869211215: -0.7%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12886858349

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.12%
Totals Coverage Status
Change from base Build 12869211215: 0.0%
Covered Lines: 358
Relevant Lines: 483
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12886858349

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.389%
Totals Coverage Status
Change from base Build 12869211215: -0.7%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

@briandfoy
Copy link
Owner

changes: support 1-byte hex format

@briandfoy briandfoy self-assigned this Jan 21, 2025
@briandfoy briandfoy merged commit 1bd92f5 into briandfoy:master Jan 21, 2025
21 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: od The od program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy